Open 0x6d686b opened 1 year ago
thanks for the feedback. While this is definitely not "a small amount of time" to implement I do understand what you need and why it would be useful
I will leave this open for future planning but dont expect this to be a priority as external recipes are used by only a small fraction of users and thus dont get that much attention.
Oh ok, I thought this is just a few lines of code needed. Sorry, I didn't want to make your work sound bad, I am apparently very much mistaken about the amount of time needed. My bad!
no worries, just wanted to give a reason why this will likely not be quickly implemented. will keep it on the agenda, what you are definitely correct with is that this would be a decent middle ground for the current implementation
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
It would be considerable more user friendly to be able to have full text search in the already OCR'ed PDFs that are imported via externalfiles. I do understand that by this way it isn't possible to automatically fill out the fields of the ingredients etc. However, I consider it to be a significant improvement.
E..g.
Though I am not an experienced python coder, possibly you could use the
pdftotext
package to extract the text. This step would be done in the import part I would then suggest that the content is added to the "instruction" field in the database. I think this way requires the least modification to the code base and still allows to achieve the goal.I think, it would just require to add a few lines to
cookbook/provider/local.py#L21
like:(I don't know if this would actually work, it's just from looking at the code and searching the repo!)
I think this should be doable with a very small amount of time and work but would massively improve the application.
Describe alternatives you've considered
No response
Additional context
No response