search

TandoorRecipes / recipes

Application for managing recipes, planning meals, building shopping lists and much much more!
https://docs.tandoor.dev
Other
5.56k stars 589 forks source link

Ingredient List Contains Unexpected Headers #2980

Open Svagtlys opened 8 months ago

Svagtlys commented 8 months ago

Tandoor Version

1.5.11

Setup

Docker / Docker-Compose

Reverse Proxy

Caddy

Other

Technically Caddy Docker Proxy by Lucas Lorentz

Bug description

Sometimes Tandoor mixes step titles in with ingredient headers in the ingredient list at the top of the recipe. Example recipe below. I don't know how to get relevant logs for this, let me know if there are steps to do so and I will!

https://food.rhythmichome.xyz/view/recipe/64/2aaaf10e-802b-45e8-b773-c3e6e1b284ac

Relevant logs

No response

smilerz commented 8 months ago

I don't see anything incorrect. Can you please use screenshots and explain exactly what you have configured and what your expected behavior is to be?

Svagtlys commented 8 months ago
From the fish stew, the ingredient list at the top of the recipe: ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/08c36dbf-ca2f-4c26-8c58-33e015481448)
I expected this list to not include the "Cook with the fish" header, as that is a step title, not an ingredient header: ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/ed5d4f59-bb09-4a8f-8ca0-d2ae0f1bc19c)

If adding the step titles is intended, I would have expected Tandoor to add all of the step titles, or to skip adding a step title when there were no ingredients under the step.

This is an example where both ingredient headers and step titles are present in the ingredient list at the top of the recipe: https://food.rhythmichome.xyz/view/recipe/149/237d8858-69bb-4589-9118-94b13503518f ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/186d957a-12e5-4505-b463-e1fb064393dc) ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/cbb05b8d-d1fd-44ee-a7da-cd83d6458e84)
And this is an example where only the ingredient headers and no step titles are present in the ingredient list at the top of the recipe: https://food.rhythmichome.xyz/view/recipe/103/043ad229-a7d7-462d-b66f-26603c529ba1 ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/46050617-f7e1-40d2-b4d8-7100319db19e) ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/6a396bf1-46da-434f-b4eb-d93b3083466e)
I've also seen cases where only one of the step titles is used: https://food.rhythmichome.xyz/view/recipe/69/7fc90721-4fb3-405e-bd17-e404bb608d99 ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/84181842-9dd1-4868-bb8e-5c44ca56fb8c) ![image](https://github.com/TandoorRecipes/recipes/assets/45446348/392156ff-b491-41f8-afb5-48b628bdcbc8)

To be honest, I'm mostly just confused with how Tandoor is determining when to use step titles or ingredient headers or both or only one of them? I don't change any options within the recipes themselves as far as I'm aware, so the differences seem purely random. This may not be a bug, but some clarity on how it works if it's working as intended would be greatly appreciated.