search

TandoorRecipes / recipes

Application for managing recipes, planning meals, building shopping lists and much much more!
https://docs.tandoor.dev
Other
5.56k stars 589 forks source link

Cup missing from base unit conversions #3258

Open PeterAttardo opened 3 months ago

PeterAttardo commented 3 months ago

Tandoor Version

1.5.18

Setup

Docker / Docker-Compose

Reverse Proxy

No reverse proxy

Other

No response

Bug description

I noticed that nutrition information was not being calculated for certain foods in my recipes. I eventually figured out that it was because the quantities were specified in tbsp in the recipe, but the conversion for that food was cup <-> g, and tandoor was failing to automatically handle the tbsp <-> cup conversion. Looking at the code, it appears that cup is missing from the conversion table constant. Given its prevalence in US recipes, I think cup should be a base volume unit, and it appears it was considered as such in the initial proposal. It may have been overlooked during implementation.

Relevant logs

No response

vabene1111 commented 3 months ago

I think you are right, cup is a basic volumetric unit, even tough it varies strongly depending on region but still, it should be in there.