TangSoftwareLab / SynergyFinderR

SynergyFinder R package development
https://www.bioconductor.org/packages/release/bioc/html/synergyfinder.html
Mozilla Public License 2.0
1 stars 1 forks source link

SynergyFinder2 vs SynergyFinder Plus (ORG?) #2

Open IanevskiAleksandr opened 2 years ago

IanevskiAleksandr commented 2 years ago

There is indeed a typo in the SynergyFinder 2.0 manuscript "-" sign should be "+" at the end of multi-drug combination Bliss synergy formula, but in the code it is correct. We will put the note on SynergyFinder v3 (that is accepted to NAR) that there is a typo in the SynergyFinder 2.0 manuscript in Bliss and ZIP equations, but the formula is (and was) correct on the website, so it doesn't affect any previous or future analysis.

For example, for 3 drug combination, we actually calculate Bliss as g123 = g1 · g2 · g3 in the code of SynergyFinder.Fimm.Fi website. Thus, for 3 drugs providing responses e.g. g1 = 35 %inhibition, g2 = 57 %inhibition, g3 = 44 %inhibition, we calculate Bliss effect as 100(1-(1-0.35)(1-0.57)(1-0.44)) = 84.348. This is exactly the same as 35+57+44 - (35x44)/100 - (57x44)/100 - (35x57)/100 + 35x44x57/10000 = 84.348. In addition, in our code implementation for ZIP, we first fit d-r curves for each observed row in 3d cube, and then run Bliss on those "fitted" data.

It is a pity that you are making such claims (and spending time, that you could spend on REAL research, on making such comparisons) without trying to contact us first, and without even trying to use the tool, otherwise, you would notice that calculations are correct, and we just have a typo in the manuscript.

TangSoftwareLab commented 1 year ago

More comments can be viewed at www.synergyfinder.org Posted here: On July 2022, the authors of SynergyFinder2 published ‘Correction to ‘SynergyFinder 2.0: visual analytics of multi-drug combination synergies’’ at https://doi.org/10.1093/nar/gkac552. It stated that “In the originally published version of this manuscript, there is an error in the Bliss and ZIP equations. There should be a ‘+’ sign instead of ‘-’, before the last term. However, the authors advise that the formulas are correct in the codes used for calculation on the website, so the error doesn’t affect any previous or future analysis with SynergyFinder.”

However, the statement was false. The sign before the last term should depend on the parity in the combination. If the number of drugs is odd, e.g. a 3-drug combination, then the sign should be ‘+’, as the authors corrected. However, if the number is even, e.g. a 4-drug combination, the sign should be ‘-’.

Furthermore, the erratum did not solve the issues concerning the Loewe model. If SynergyFinder3 continues to use the formula S_LOEWE=a/A+b/B to determine the Loewe synergy score, then it is still inconsistent with the definition of Loewe models. The problem of Loewe model may be inherent irrespective of the size of the combination, which may explain why the results between SynergyFinder⅔ and SynergyFinder+ are different, even for 2-drug combinations.

Reproducibility is a crucial issue in medical research, particularly in drug discovery. It is essential to provide mathematically sound models to avoid false interpretations of data. In conclusion, the mathematical models in SynergyFinder 2&3 contain severe flaws that require correction. Additionally, contrary to the authors' claims in the publications, we found that the source code for SynergyFinder 2 & 3 was not available. Without access to the source code, evaluating the reproducibility of the results becomes challenging. Given that there are over 400 citations of these two papers, it is crucial to inform the drug discovery community about the issues and urge them to reanalyze their datasets with the corrected models.

IanevskiAleksandr commented 1 year ago

Dear Jing,

We have made a comprehensive update of the SynergyFinder 3.0 documentation by adding more detailed information on the synergy calculations in all cases, and by providing examples of the synergy calculations. The updated content is now available online in the "Reference models" section of the technical documentation. This update is intended to provide a greater clarity for the synergy calculations, even for users who may not have a mathematical background. The updated documentation can be accessed through the following link: https://synergyfinder.fimm.fi/synergy/synfin_docs/#reference

In addition, we cross-compared the analysis results of SynergyFinder 3.0, SynergyFinderPlus, and other tools for drug synergy analysis and observed a very strong correlations between all of them, ensuring that researchers can confidently utilize any of the implementations of drug synergy analysis tools for analyzing their data and for obtaining robust and reproducible conclusions.

BR, Aleksandr

TangSoftwareLab commented 1 year ago

Dear Aleksander, We are discussing the validity of your mathematical models. In case you have corrected them as what we have discussed that would be great. The whole community deserved more transparency and openness on this issue.