search

TangSoftwareLab / SynergyFinderR

SynergyFinder R package development
https://www.bioconductor.org/packages/release/bioc/html/synergyfinder.html
Mozilla Public License 2.0
1 stars 1 forks source link

Error when changing units of concentrations #6

Closed GarrettJenkinson closed 1 year ago

GarrettJenkinson commented 1 year ago

Thank you for this helpful package. Please find below a minimal reproducible example of the error:

data("mathews_screening_data")
mathews_screening_data$conc_r <- mathews_screening_data$conc_r/10^9
mathews_screening_data$conc_c <- mathews_screening_data$conc_c/10^9
mathews_screening_data$conc_r_unit <- "M"
mathews_screening_data$conc_c_unit <- "M"
data <- ReshapeData(mathews_screening_data)
data <- CalculateSynergy(data)
plots <- PlotSynergy(data, "2D", block_ids = NULL)

Results in:

Error in dimnames(x) <- dn : length of 'dimnames' [1] not equal to array extent

This is true of many plotting functionalities. I found this is true in multiple data sets when trying to use units of M rather than nM.

shuyuzheng commented 1 year ago

Thank you for report. I have fixed this bug in version 3.7.1 (branch master, commit e18bd2c) or version 3.6.1 on Bioconductor (branch RELEASE_3_16, commit 770df6b).