search

TangSoftwareLab / SynergyFinderR

SynergyFinder R package development
https://www.bioconductor.org/packages/release/bioc/html/synergyfinder.html
Mozilla Public License 2.0
1 stars 1 forks source link

Synergyfinder package can turn off warnings for a current R session as (accidental) side effect #9

Open bioinfomagician opened 10 months ago

bioinfomagician commented 10 months ago

Hello!

Thanks for this package! Very useful for examining synergistic effects. Howeer, while using this package I have noticed that it can cause some side effects since it can change the R scipen option or the warn option from the defaults that a user might normally be expecting. Turning off warnings is in particularly a bit of the more concerning side effect here. It looks like there is an attempt to return the warn option back on in this line of code, however this line never gets executed because it comes after a return call. Would it be possible to reverse the orders of line 520 and 521 in a future version of this package?

https://github.com/TangSoftwareLab/SynergyFinderR/blob/4bcf092938f94437534f0c49b26aa95086520823/R/plot_two_drugs.R#L521

jtang920 commented 10 months ago

Hi, A good point. We will return the option in our next release of R package. Thanks. Best, Jing

From: J Brothers @.> Sent: Thursday, September 7, 2023 1:43 AM To: TangSoftwareLab/SynergyFinderR @.> Cc: Subscribed @.***> Subject: [TangSoftwareLab/SynergyFinderR] Synergyfinder package can turn off warnings for a current R session as (accidental) side effect (Issue #9)

Hello!

Thanks for this package! Very useful for examining synergistic effects. Howeer, while using this package I have noticed that it can cause some side effects since it can change the R scipen option or the warn option from the defaults that a user might normally be expecting. Turning off warnings is in particularly a bit of the more concerning side effect here. It looks like there is an attempt to return the warn option back on in this line of codehttps://github.com/TangSoftwareLab/SynergyFinderR/blob/4bcf092938f94437534f0c49b26aa95086520823/R/plot_two_drugs.R#L521, however this line never gets executed because it comes after a return call. Would it be possible to reverse the orders of line 520 and 521 in a future version of this package?

https://github.com/TangSoftwareLab/SynergyFinderR/blob/4bcf092938f94437534f0c49b26aa95086520823/R/plot_two_drugs.R#L521

— Reply to this email directly, view it on GitHubhttps://github.com/TangSoftwareLab/SynergyFinderR/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFWHIHZNI3REUB6LIT5PQTXZD37TANCNFSM6AAAAAA4OAL5ME. You are receiving this because you are subscribed to this thread.Message ID: @.***>