Tangent128 / luasdl2

A pure C binding of SDL 2.0 for Lua 5.1, Lua 5.2, and LuaJIT.
ISC License
385 stars 74 forks source link

Update Version Number #57

Closed Web-eWorks closed 7 years ago

Web-eWorks commented 7 years ago

Consider yourself poked.

Also, is the binding number independent of the SDL version number, or should it be reset on each version change? The current versioning scheme feels like the latter.

Web-eWorks commented 7 years ago

It's been 20 days, so I assume you've been busy enough to miss this. Poking again.

Tangent128 commented 7 years ago

Reminder's appreciated; can confirm busyness.

Please re-poke if you don't see a tagged/Luarocks release by March 4.

To answer versioning question, the fact that the binding tries to maintain compatibility with multiple SDL versions and multiple Lua versions, while potentially having to bugfix itself now and then, makes the versioning scheme non-obvious.

For now, I'm following the previous maintainer's pattern and having the main version number track the supported SDL version, while keeping the binding version independent. I'm not fully satisfied with the scheme, but I also don't have a clearly better idea.

Web-eWorks commented 7 years ago

Edit: Moved response to #58.

Web-eWorks commented 7 years ago

One re-poke-ination. Assuming, again, horrible busyness.

Tangent128 commented 7 years ago

Thanks for reminder; have tagged 2.0.5-6 (yeah, a new versioning scheme is needed...) and will upload rockspec shortly.

There was one compilation bug in gamecontroller.c I had to fix concerning its #inclusion of rwops.