Open rjcorwin opened 2 years ago
The diff algorithm gets tripped up.
@evansdianga MVP on this would be to at least not crash and instead of a diff show a message on the proposal that says something like "See proposal for differences". Perhaps we just put this in a try catch for now.
Current version: v3.20.x Upgraded from: Issue on tablet and/or server:
Expected behavior
After making a proposal on a form response involving a
<tangy-inputs-groups>
, we may have added one more or one less items in that input groups, we would expect diff output to explain that to us after submitting the proposal.Actual behavior
After submitting the proposal, the issue fails to load.
Steps to reproduce the behavior
On a Device, create a case and fill out a form response on a form that uses
<tangy-input-groups>
then upload that data. On the server, find that Case, create an issue on that Form Response you filled out earlier, make a proposal, and on the<tangy-input-groups>
section, try either adding or removing a group, then submit the proposal. When the Issue then tries to load it will crash, see console for error. This has to do with the fact that when you add/remove items in a tangy input groups, the variable names change in the form because additional inputs in a tangy inputs group gets appended an enumeration but our diff algorithm doesn't know how to diff it. It doesn't know how to diff it so much that it ends up crashing the loading of an issue.