* Added Open All and Close All Buttons

Tangerine-Community / tangy-form

<tangy-form> is a web component for creating multipage forms. Other <tangy-*> input elements are included as well.

GNU General Public License v3.0

15 stars 3 forks source link

* Added Open All and Close All Buttons #203

Closed evansdianga closed 3 years ago

evansdianga commented 3 years ago

Added event hadlers to click all the open items when either button is clicked
Closes Tangerine-Community/Tangerine#2596
@mikeymckay

rjcorwin commented 3 years ago

@evansdianga @mikeymckay Well done! I merged in my branch with the test for opening all items and the code you wrote passed. I'll merge this for release.

On Wednesday's code review let's review this. A couple of topics to cover:

How the same end could be reached using a Redux Action vs. DOM manipulation.
Writing a test for closing all items.
Why Kent C. Dodds might be showing up as the person who committed this code :-P.

mikeymckay commented 3 years ago

I never thought I could be so excited about a code review meeting!