TangibleInc / template-system

A template system for WordPress with content type loops and conditions
https://docs.loopsandlogic.com/reference/template-system/
6 stars 2 forks source link

Overview - Upgrade to new editor #8

Open eliot-akira opened 9 months ago

eliot-akira commented 9 months ago

This is an overview of tasks related to the recent upgrade of the code editor.

Formatter

Builder integrations

Improvements


About the upgrade from CodeMirror 5 to 6

New editor

Documentation for the new editor: https://docs.loopsandlogic.com/reference/template-system/editor/

The new editor based on CodeMirror 6 is enabled by default in the template post type edit screen (Template, Style, Script, and Control) and in Gutenberg. However, in the Elementor and Beaver Builder integrations, the old editor is still needed until compatibility issues are resolved.

Old editor

The old editor based on CodeMirror 5 has been archived to its own repository.

Its minified bundle without source maps is still in the Template System, until the new editor fully replaces it: modules/codemirror-5.

studioavanti commented 7 months ago

Hi,

When using the Tangible module to edit a L&L Template directly in a Beaver Builder layout, there's a styling conflict impacting the module's readability. Beneath the editor, the Settings part is in dark mode with all text dark as well.

This is the L&L CSS rule involved and how i fixed it by modifying the selector:

.fl-lightbox .tangible-template-system--editor-actions-panel * {
    color: #fff;
}

…instead of just:

.tangible-template-system--editor-actions-panel {
    color: #fff;
}

…which is overwritten by a BB rule.

CleanShot 2024-02-11 at 18 27 25

eliot-akira commented 6 months ago

Thank you @studioavanti. As you discovered, there's a known issue with Beaver Builder's overly-eager CSS rules causing conflict with the new code editor. I appreciate the suggested fix, I'll try that.