[BTE-11C] Suboptimal Struct Declaration Styles - Githubissues

TangibleTNFT / baskets-foundry

baskets-foundry

1 stars 0 forks source link

[BTE-11C] Suboptimal Struct Declaration Styles #48

Closed chasebrownn closed 7 months ago

chasebrownn commented 7 months ago

BTE-11C: Suboptimal Struct Declaration Styles

Type	Severity	Location
Code Style		Basket.sol:L299, L564, L690, L718, L754, L860

Description:

The linked declaration styles of the referenced structs are using index-based argument initialization.

Example:

nextToRedeem = RedeemData(tnft, tokenId);

Recommendation:

We advise the key-value declaration format to be utilized instead in each instance, greatly increasing the legibility of the codebase.

chasebrownn commented 7 months ago

Acknowledged