TangoTek / TekTopia-Community

Bug/Issue tracking for TekTopia testing
35 stars 12 forks source link

Suggestion: Miners pick up all 'ores', even non-Vanilla ones. #333

Open HexFlareheart opened 5 years ago

HexFlareheart commented 5 years ago

So, for those who don't know, there's a really cool thing built into Forge called the Ore Dictionary; it does a lot of things, but the main thing I want to draw attention to right now is the way ores (and related items) are labeled. Iron ore in the ore dictionary, for instance, is oreIron. Anything can be assigned a label that's basically a type (ore, ingot, gem, nugget, dust, etc.) and a name.

So my proposal here is to use this to allow Miners to pick up and store any block they mine that is classified in the Ore Dictionary as, well, an 'ore'. Even if they can't necessarily use the ores, it'd be nice to have them pick them up anyway. In theory, this should be relatively simple to implement. Relatively. (Take my word with a grain of salt, I haven't coded a Minecraft mod.)

(Similarly, it'd be nice if Blacksmiths could detect if ores in storage have an ingot counterpart, and if the ore can be smelted into said ingot, and thus try making ores into ingots. This is likely much more complicated of an idea, though.)

Obviously, neither of these ideas is really a 'priority'. Just a thought for later down the line.

JohnyDL commented 5 years ago

I touched on an alternate way to do this in #65 I'm glad it's getting its own thread.

if a block is not {cobble, stone, stone variant, dirt. gravel bedrock, spawner} or (only applies to the listed items) if total block count in storage/all villager inventories %64 is not 0 and /64 is less than or equal to the number of partial stacks in storage -then add the block or it's drop to inventory -else void block/drop

This would allow miners to collect cobble, stone, stone variants, dirt. gravel and even loot/rails if they luckily run into a mine shaft for the player to use and how much they bring back is entirely controllable by the player ;)

Don't know so much about auto smelting them but auto collecting them would be super nice