Tangshitao / MVDiffusion

MVDiffusion: Enabling Holistic Multi-view Image Generation with Correspondence-Aware Diffusion, NeurIPS 2023 (spotlight)
480 stars 25 forks source link

fix arg passed error in func get_correspondence #34

Closed kkaiwwana closed 11 months ago

kkaiwwana commented 11 months ago

Hi, Tang. I found another bug which is similar to #24: the args passed get_x_2d ought to be (w, h). Unlike #24, it didn't raise an explicit error when height: width of inputs is not 1:1, this part of code just returns wrong correspondence in that case, which made my training failed.

Thank you.

Tangshitao commented 11 months ago

Thanks for the fix!