TanguyAladenise / BBBadgeBarButtonItem

A BarButtonItem with a badge on top.
MIT License
963 stars 154 forks source link

Please don't delete your release tags #15

Closed betzerra closed 10 years ago

betzerra commented 10 years ago

You're breaking our projects that are using cocoapods with the following Podfile

pod 'BBBadgeBarButtonItem',
        :git => 'https://github.com/TanguyAladenise/BBBadgeBarButtonItem',
        :tag => '1.0'
TanguyAladenise commented 10 years ago

Sorry, is it okay now ?

betzerra commented 10 years ago

hahaha... yes, we updated to 1.1 and everything's okay :smile:

TanguyAladenise commented 10 years ago

Sorry, this is my first cocoapod repo. Now 1.0 is before 1.1 ^^. I will update in the future. Sorry about that.

rwyland commented 10 years ago

Is there any way you can restore the 1.0 branch to what it actually was? Something is wrong with your new tags. The tag for v1.0 does not seem to contain the commit that added:

// Padding value for the badge
@property (nonatomic) CGFloat badgePadding;
// Minimum size badge to small
@property (nonatomic) CGFloat badgeMinSize;
// Values for offseting the badge over the BarButtonItem you picked
@property (nonatomic) CGFloat badgeOriginX;
@property (nonatomic) CGFloat badgeOriginY;

So now one of the tags for our git project is not restoring properly because of errors due to these properties not existing.