search

TanguyOrtegat / esx_jb_eden_garage2

41 stars 50 forks source link

Garage Bug #19

Closed Matt62exe closed 5 years ago

Matt62exe commented 5 years ago

the garage at the end of 36 vehicles can not go out of the vehicle anymore

TanguyOrtegat commented 5 years ago

yes, messagepack error... make sure players do not have more then 30 vehicles (to be sure)

Matt62exe commented 5 years ago

he has opportunity to fix this problem ?

TanguyOrtegat commented 5 years ago

this problem is related to lua, not this sctipt, all you can do is a check in vehicleshop that people having more then 30 veicles, cannot buy more then that, they must sell some cars, in order to buy some now ones

ElPumpo commented 5 years ago

I think there is some sort of memory limit.. You can usally fix it by narrowing down the infofmation you display in the esx menus.

For example in esx_vehicleshop I disabled the colored money and that solved the issue for me.

TanguyOrtegat commented 5 years ago

I think there is some sort of memory limit.. You can usally fix it by narrowing down the infofmation you display in the esx menus.

For example in esx_vehicleshop I disabled the colored money and that solved the issue for me.

i ll see what i can do, the thing what is taking place is the 'vehicle' column un database. wut we need to get it client sided to apply the customisation. i ll try to look for fix. But saying that, a player having more then 30 vehicles, did he buy all your vehicle shop? your economy is then not right (that's my opinion)

ElPumpo commented 5 years ago

I found the problem dude, here https://github.com/TanguyOrtegat/esx_jb_eden_garage2/blob/master/esx_jb_eden_garage2_cl.lua#L159

You're saving all vehicle props as the elements, which is a bad practise. That's why your menu breaks with only 30 cars, but in esx_vehicleshop we can have around 300-500 vehicles before it breaks.