TanguyOrtegat / esx_jb_eden_garage2

41 stars 50 forks source link

Doesn't despawn the old vehicle #27

Closed thegambid closed 5 years ago

thegambid commented 5 years ago

When we get the car back from yellow circle with payment, it gives the car to the player but it doesn't despawn the old one and that causes dupe of the vehicle. Hope you help me fix that soon.

TanguyOrtegat commented 5 years ago

normally if you get updated code, you cannot take the car if the car is somewhere on the world

thegambid commented 5 years ago

normally if you get updated code, you cannot take the car if the car is somewhere on the world

But it doesn't work correctly. What do you recommend me to do?

TanguyOrtegat commented 5 years ago

can you try the fixes ? thanks

thegambid commented 5 years ago

I've installed your latest fixes. My tests: When I try to get the car when an another player is in it and I'm at a too far away from that garage and try to get vehicle from yellow point, it says st like "you can't take it" and doesn't give me the vehicle, but when that player gets out of my car and I try it at the same place it gives me the car but still doesn't despawn the other one.

My question is if its not gonna work, can we disable yellow circle for good? That'd probably fix my issue.

TanguyOrtegat commented 5 years ago

no, if player disconnects and reconnects he can get his vehicle back

thegambid commented 5 years ago

Nope, this dupe works without reconnecting either.

TanguyOrtegat commented 5 years ago

weird, what do you do ? and what kind of plates you working with?

thegambid commented 5 years ago

"XXX 999" formatted plates

TanguyOrtegat commented 5 years ago

hmmm that's weird because i did try with spaced plates too and it is working. maybe i can debug it on your sevrer ?

thegambid commented 5 years ago

It'd be a great pleasure. We have a test server. How do we contact?

TanguyOrtegat commented 5 years ago

here is my discord: Jager Bom [dev]#2795

TanguyOrtegat commented 5 years ago

just UPDATE the script