TanguyOrtegat / esx_jb_eden_garage2

41 stars 50 forks source link

Few "problems" with the new version #47

Closed TarisGN closed 5 years ago

TarisGN commented 5 years ago
TanguyOrtegat commented 5 years ago

hey, thanks for the "issues" normally you can park free your vehicles wherever you want, but if you parked in noth garage and you want to get out in south you will have to pay fee. i ll try when i got the time the other issues

TanguyOrtegat commented 5 years ago

i just heard a bug from my players if you put vehicle out and go to other gaage and want to take out same vehicle it teleports you to other garage. will have a look into it

TarisGN commented 5 years ago

hey, thanks for the "issues" normally you can park free your vehicles wherever you want, but if you parked in noth garage and you want to get out in south you will have to pay fee. i ll try when i got the time the other issues

Can it be related to database ? because for me, players can park vehicles on another garage, but they have to wait for a reboot to have it for "free", by default, if they park, garage ask to pay the fee

JogiTE commented 5 years ago

I can confirm that we have the same problems. Garage location is usually only after the second time parked in the same garage in the database. And that with teleporting happens here as well.

TanguyOrtegat commented 5 years ago

thanks for reporting! will try to fix it as soon as possible but going to vacation so big chance will be afterward.

Alevhovic commented 5 years ago

Hi @TanguyOrtegat

Your update is really good, but as @JogiTE say. We have some "new" issue with it.

Just a little question : What "vehiclelock" script are you using on your server ?

TanguyOrtegat commented 5 years ago

@Alevhovic i am using my own vehicle lock script. issues will be debugged after 12 september. when i come back from vacation.

maguhd commented 5 years ago

I have the same issues as the guys above me :) Waiting for the fix. Have a nice vacation!!!

madalton commented 5 years ago

bonsoir,

j ai print un peu partout avec print(vehicleProps) pour comprendre a quel moment le script passait a l'ancien vehicule et c est en passant dans ce bout de code. si cela peux aider, j ai fais plein de modif sans succes.... je miserais sur elements = elem qui efface le nouveau vehicule precedement selectionne ?

ESX.UI.Menu.Open( 'default', GetCurrentResourceName(), 'transfer_menu', { css = 'vehicle', title = "Voulez vous transférer: "..data.current.vehicleName.." a votre garage?", align = 'top-left', elements = elem, },

bon courage ! et encore merci j adore votre travail.

iTzCrutchie commented 5 years ago

Just wanted to report also having the same issue as bullet point two. It pulls out the first vehicle you transferred. You have to store it in that garage twice and then the second vehicle you want will appear. Happens with any new vehicle you want to transfer to the garage.

Another issue I found is that right after you transfer the vehicle to the new garage, if you don't store it then you can pull it out multiple times and have multiple of the same vehicle out. This issue gets fixed if you store the vehicle before pulling it out of the garage again.

TanguyOrtegat commented 5 years ago

can someone look if everything is fixed ?

Boom1053 commented 5 years ago

its not fixed the second car still spawns the first car. And everyone keeps teleporting across the map when they transferred the car from one place to another.

iTzCrutchie commented 5 years ago

Just manually pushed this update to my scripts as I have translated everything to English and didn't want to lose the translation..

Anyways it appears to be working on my end. Transferred the first vehicle to a new garage stored it then went back and pulled my second vehicle out no problem

Also it is stating i can not pull out the vehicle again after i have already transferred/pull it out at the new garage. And not teleporting across the map. Though I didn't have that issue to begin with.

madalton commented 5 years ago

Hi,

when i want transfered 2 car and if first car is not stored and i call second car, garage spawn my first car.

TanguyOrtegat commented 5 years ago

should be fixed by now

madalton commented 5 years ago

hi,

yes is perfect. Thx

iTzCrutchie commented 5 years ago

So I am teleporting across the map when pulling out vehicles. It appears that with the first time you transfer a vehicle to a new garage after storing it in a different garage it will teleport you to the garage you originally stored the vehicle in. Once it teleports you if you go back to the garage where you initiated the transfer to begin with and store the vehicle you will not telpeort when you pull it back out.

EDIT: Actually it happened twice in row but now i cant reproduce it.

TanguyOrtegat commented 5 years ago

@iTzCrutchie never had that problem on my end.. but could be an issue. Could you explain step by step what you did so i can try myself and test it out and debug if it happens :)

iTzCrutchie commented 5 years ago

@TanguyOrtegat Sure thing.

  1. Transfer the vehicle to a new garage. ( I was using Pillbox Garage)
  2. Vehicle was transferred out and spawned in Pillbox normally
  3. Stored vehicle in Pillbox Garage
  4. Went to Grove street garage and transferred the vehicle to grove street
  5. Transfer was successful but teleported to Pillbox

It only happened twice but wasn't able to replicate it after that.

TanguyOrtegat commented 5 years ago

@TanguyOrtegat Sure thing.

  1. Transfer the vehicle to a new garage. ( I was using Pillbox Garage)
  2. Vehicle was transferred out and spawned in Pillbox normally
  3. Stored vehicle in Pillbox Garage
  4. Went to Grove street garage and transferred the vehicle to grove street
  5. Transfer was successful but teleported to Pillbox

It only happened twice but wasn't able to replicate it after that.

hey, thanks for detailed debug, but tried many times, still not teleported ...

iTzCrutchie commented 5 years ago

I havent teleported either. I believe we are all good now. Thanks for the quick update :)

TanguyOrtegat commented 5 years ago

closing the issue