Tanguygab / TAB-Additions

An addon for the TAB minecraft plugin with some more cool features :D
GNU General Public License v3.0
14 stars 3 forks source link

Possibility to fix this issue? #22

Closed catches closed 1 year ago

catches commented 1 year ago

Normal players can do this: image

Tanguygab commented 1 year ago

try to redownload 1.6.7 https://github.com/Tanguygab/TAB-Additions/releases/download/1.6.7/TAB-Additions-1.6.7.jar

catches commented 1 year ago

Thanks, that seemed to have fix it, also is the /msg command registered? Because if I type it in console, it registers a different output which seems to be from default EssentialsX: image

You could also make it not tab complete the * or ** image

Tanguygab commented 1 year ago

It should have registered, weird, I don't think my cmd works in the console though. * and ** are probably also because of Essentials's /msg. Maybe try disabling it in its config.yml image

catches commented 1 year ago

Looks like disabling the command in EssentialsX fixed the * and **, thanks. Is there any reason your command won't work through console? What about if a plugin needs to message the player through console like for example [CONSOLE] msg Player Hi

Tanguygab commented 1 year ago

most plugins have a message action like [msg] or [message], I don't really see a reason to be able to use it from console so I didn't add support for it

catches commented 1 year ago

Hmm I see, idk if you could possibly add support for console, but if it's too much work, it's fine.

catches commented 1 year ago

Yo @Tanguygab, for chat emojis, I added the permission tabadditions.chat.emoji.<3 but I don't seem to have it. image Is there a category permission? I have it added, but it doesn't work. image

Tanguygab commented 1 year ago

image depending on your configuration, if you have permission: category, you'll need tabadditions.chat.emoji.category.<category>, if it's permission: emoji, you'll need tabadditions.chat.emoji.<emoji>, if you don't specify the option, you don't need any permission to use emojis from this category.

catches commented 1 year ago

Thanks, that worked. BTW, is it possible to add a toggle global chat function?

Tanguygab commented 1 year ago

How would that work?

catches commented 1 year ago

Basically, a player just types like /tgc, toggles the public global chat, but allows private messages if they have that on. Plugin messages and stuff like that would still go through, if that's possible.

Tanguygab commented 1 year ago

so, it would hide all msgs except private msgs? alright, should I also block the ability to send msgs? like, say "you toggled global chat off!"

catches commented 1 year ago

You should allow messages from plugins to be sent, like command outputs, etc.

Tanguygab commented 1 year ago

yeah, just chat messages from other players are blocked, I get it

catches commented 1 year ago

yo getting this message when the server restarts/stops, or when I /tab reload, seems to break it

[13:36:07 ERROR]: Error occurred while disabling TAB-Additions v1.6.7 (Is it up to date?) java.lang.NoClassDefFoundError: me/neznamy/tab/platforms/bukkit/nms/NMSStorage at io.github.tanguygab.tabadditions.spigot.SpigotPlatform.removeFromChatComplete(SpigotPlatform.java:170) ~[TAB-Additions-1.6.7.jar:?] at io.github.tanguygab.tabadditions.shared.features.chat.ChatManager.unload(ChatManager.java:246) ~[TAB-Additions-1.6.7.jar:?] at io.github.tanguygab.tabadditions.shared.TABAdditions.lambda$disable$1(TABAdditions.java:144) ~[TAB-Additions-1.6.7.jar:?] at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?] at io.github.tanguygab.tabadditions.shared.TABAdditions.disable(TABAdditions.java:142) ~[TAB-Additions-1.6.7.jar:?] at io.github.tanguygab.tabadditions.spigot.TABAdditionsSpigot.onDisable(TABAdditionsSpigot.java:33) ~[TAB-Additions-1.6.7.jar:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:266) ~[pufferfishplus-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:402) ~[pufferfishplus-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:581) ~[pufferfishplus-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:558) ~[pufferfishplus-api-1.19.3-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_19_R2.CraftServer.disablePlugins() ~[pufferfishplus-1.19.3.jar:git-PufferfishPlus-40] at net.minecraft.server.MinecraftServer.t(MinecraftServer.java) ~[pufferfishplus-1.19.3.jar:git-PufferfishPlus-40] at net.minecraft.server.dedicated.DedicatedServer.t(DedicatedServer.java) ~[pufferfishplus-1.19.3.jar:git-PufferfishPlus-40] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java) ~[pufferfishplus-1.19.3.jar:git-PufferfishPlus-40] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java) ~[pufferfishplus-1.19.3.jar:git-PufferfishPlus-40] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.ClassNotFoundException: me.neznamy.tab.platforms.bukkit.nms.NMSStorage ... 16 more

Tanguygab commented 1 year ago

I haven't updated TAB-Additions to newer TAB versions yet, I'll do it. Also, please open a different issue for each issue individually next time

Tanguygab commented 1 year ago

https://github.com/Tanguygab/TAB-Additions/releases/tag/1.6.8