search

Tanguygab / TAB-Additions

An addon for the TAB minecraft plugin with some more cool features :D
GNU General Public License v3.0
15 stars 4 forks source link

Problem with property named nametag-in-range #31

Closed TeQTabanca closed 1 year ago

TeQTabanca commented 1 year ago

If I add more than 1 number to the nametag-in-range property and use the /tab reload command each time, the player's nametag stays in the position it expects.

TAB Version: 3.3.2

TAB-Additions Version: 1.7.1

Minecraft Version: 1.12.2-Spigot

image image

Tanguygab commented 1 year ago

send your config

TeQTabanca commented 1 year ago

send your config config.zip

Tanguygab commented 1 year ago

Disable conditional-nametags

TeQTabanca commented 1 year ago

Disable conditional-nametags

Still same

Tanguygab commented 1 year ago

disable it and restart, it should be fine afterwards

TeQTabanca commented 1 year ago

disable it and restart, it should be fine afterwards

I restarted the server but still the same

Tanguygab commented 1 year ago

I don't know what's wrong then, it works fine for me

TeQTabanca commented 1 year ago

I don't know what's wrong then, it works fine for me

I think it might be because of this bug.

09.05.2023 - 11:49:13 - [TAB v3.3.2] Tried to modify non-existing team 7TeqTabancaA for player Test
09.05.2023 - 11:49:13 - [TAB v3.3.2] Tried to modify non-existing team 6TestA for player TeqTabanca
09.05.2023 - 11:49:13 - [TAB v3.3.2] An error was thrown when executing task
09.05.2023 - 11:49:13 - java.lang.NullPointerException: Cannot invoke "me.neznamy.tab.shared.features.PlaceholderManagerImpl.getPlaceholder(String)" because the return value of "me.neznamy.tab.shared.TAB.getPlaceholderManager()" is null
09.05.2023 - 11:49:13 -     at me.neznamy.tab.shared.placeholders.TabPlaceholder.setPlaceholders(TabPlaceholder.java:136)
09.05.2023 - 11:49:13 -     at me.neznamy.tab.shared.placeholders.PlayerPlaceholderImpl.updateValue(PlayerPlaceholderImpl.java:85)
09.05.2023 - 11:49:13 -     at me.neznamy.tab.shared.placeholders.PlayerPlaceholderImpl.lambda$updateValue$0(PlayerPlaceholderImpl.java:91)
09.05.2023 - 11:49:13 -     at me.neznamy.tab.shared.CpuManager.lambda$submit$1(CpuManager.java:84)
09.05.2023 - 11:49:13 -     at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
09.05.2023 - 11:49:13 -     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
09.05.2023 - 11:49:13 -     at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
09.05.2023 - 11:49:13 -     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
09.05.2023 - 11:49:13 -     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
09.05.2023 - 11:49:13 -     at java.base/java.lang.Thread.run(Thread.java:833)
TeQTabanca commented 1 year ago

By the way, I tried the developer build of TAB-4.0.0-SNAPSHOT. The TAB-Additions plugin does not open.

[21:37:12 INFO]: [TAB] Enabling TAB v4.0.0-SNAPSHOT
[21:37:12 INFO]: [TAB] Server version: 1.12.2 (v1_12_R1)
[21:37:12 INFO]: [TAB] Loaded NMS hook in 17ms
[21:37:12 INFO]: [TAB] Enabled in 222ms
[21:37:12 INFO]: [TAB-Additions] Enabling TAB-Additions v1.7.1
[21:37:12 ERROR]: Error occurred while enabling TAB-Additions v1.7.1 (Is it up to date?)
java.lang.NoClassDefFoundError: me/neznamy/tab/api/config/ConfigurationFile
        at io.github.tanguygab.tabadditions.spigot.TABAdditionsSpigot.onEnable(TABAdditionsSpigot.java:18) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[server.jar:git-Spigot-79a30d7-f4830a1]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) [server.jar:git-Spigot-79a30d7-f4830a1]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:403) [server.jar:git-Spigot-79a30d7-f4830a1]
        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugin(CraftServer.java:381) [server.jar:git-Spigot-79a30d7-f4830a1]
        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugins(CraftServer.java:330) [server.jar:git-Spigot-79a30d7-f4830a1]
        at net.minecraft.server.v1_12_R1.MinecraftServer.t(MinecraftServer.java:422) [server.jar:git-Spigot-79a30d7-f4830a1]
        at net.minecraft.server.v1_12_R1.MinecraftServer.l(MinecraftServer.java:383) [server.jar:git-Spigot-79a30d7-f4830a1]
        at net.minecraft.server.v1_12_R1.MinecraftServer.a(MinecraftServer.java:338) [server.jar:git-Spigot-79a30d7-f4830a1]
        at net.minecraft.server.v1_12_R1.DedicatedServer.init(DedicatedServer.java:272) [server.jar:git-Spigot-79a30d7-f4830a1]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:545) [server.jar:git-Spigot-79a30d7-f4830a1]
        at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.ClassNotFoundException: me.neznamy.tab.api.config.ConfigurationFile
        at java.net.URLClassLoader.findClass(URLClassLoader.java:445) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:152) ~[server.jar:git-Spigot-79a30d7-f4830a1]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:100) ~[server.jar:git-Spigot-79a30d7-f4830a1]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:587) ~[?:?]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
        ... 12 more
Tanguygab commented 1 year ago

obviously, you'd expect thugs to break when a plugin switches from 3.x to 4.0. I did update TAB-Additions but didn't release it yet, here's a jar if you want to try TAB-Additions-2.0.0-SNAPSHOT.jar.zip

Be aware that TAB-Additions 2.0.0 has a completely different config.yml, so you'll need to delete the entire folder to let it regenerate

TeQTabanca commented 1 year ago

obviously, you'd expect thugs to break when a plugin switches from 3.x to 4.0. I did update TAB-Additions but didn't release it yet, here's a jar if you want to try TAB-Additions-2.0.0-SNAPSHOT.jar.zip

Be aware that TAB-Additions 2.0.0 has a completely different config.yml, so you'll need to delete the entire folder to let it regenerate

It works fine now, but when I use the nametag-in-range property, it throws an error in the error.log file.

Error.log

09.05.2023 - 22:50:01 - [TAB v4.0.0-SNAPSHOT] Tried to modify non-existing team 7TeqTabancaA for player Test
09.05.2023 - 22:50:01 - [TAB v4.0.0-SNAPSHOT] Tried to modify non-existing team 6TestA for player TeqTabanca

Debug

[22:50:01 INFO]: TeqTabanca issued server command: /tab reload
[22:50:01 INFO]: [TAB] [DEBUG] Feature HeaderFooter processed unload in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature BukkitPipelineInjector processed unload in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature YellowNumber processed unload in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature NameTag processed unload in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature PlayerList processed unload in 1ms
[22:50:01 INFO]: [TAB] [TAB v4.0.0-SNAPSHOT] Tried to modify non-existing team 7TeqTabancaA for player Test
[22:50:01 INFO]: [TAB] [TAB v4.0.0-SNAPSHOT] Tried to modify non-existing team 6TestA for player TeqTabanca
[22:50:01 INFO]: [TAB] [DEBUG] Feature NametagInRange processed unload in 0ms
[22:50:01 INFO]: [TAB] Disabled in 2ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature PlaceholderManagerImpl processed load in 1ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature HeaderFooter processed load in 1ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature BukkitPipelineInjector processed load in 1ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature YellowNumber processed load in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature Sorting processed load in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature NameTag processed load in 0ms
[22:50:01 INFO]: [TAB] [DEBUG] Feature PlayerList processed load in 1ms
[22:50:01 INFO]: [TAB] Enabled in 12ms
Tanguygab commented 1 year ago

I'll check, when I get home

TeQTabanca commented 1 year ago

I'll check, when I get home

By the way, when you turn on the unlimited-nametag-mode feature in the TAB plugin's config.yml file, and set the nametag-in-range property to more than 1, the player's name tag stays in the position it expects after the /tab reload command.

TeQTabanca commented 1 year ago

Why doesn't the nametag-in-range property work properly with the conditional-nametags and unlimited-nametag-mode property?

TeQTabanca commented 1 year ago

Any chance of adding a fix to make it work properly?

Tanguygab commented 1 year ago

By the way, when you turn on the unlimited-nametag-mode feature in the TAB plugin's config.yml file, and set the nametag-in-range property to more than 1, the player's name tag stays in the position it expects after the /tab reload command.

Works fine for me

Why doesn't the nametag-in-range property work properly with the conditional-nametags and unlimited-nametag-mode property?

nametag-in-range and conditional-nametags aren't meant to be used together. Either way, I fixed the error here

TAB-Additions-2.0.0-SNAPSHOT.zip

TeQTabanca commented 1 year ago

By the way, when you turn on the unlimited-nametag-mode feature in the TAB plugin's config.yml file, and set the nametag-in-range property to more than 1, the player's name tag stays in the position it expects after the /tab reload command.

Works fine for me

Why doesn't the nametag-in-range property work properly with the conditional-nametags and unlimited-nametag-mode property?

nametag-in-range and conditional-nametags aren't meant to be used together. Either way, I fixed the error here

TAB-Additions-2.0.0-SNAPSHOT.zip

The moment I turn on the conditional-nametags feature, the nametag-in-range feature is not used, and the nametag-in-range feature is still not used even though I turned off the conditional-nametags feature. Finally, the issue with the unlimited-nametag-mode attribute seems to be fixed in this version.

TeQTabanca commented 1 year ago

In the anti-override.log file this text rarely appears.

10.05.2023 - 14:09:32 - [TAB v4.0.0-SNAPSHOT] Something just tried to add player Test into team ETest (expected team: ￿26TestA)
Tanguygab commented 1 year ago

The moment I turn on the conditional-nametags feature, the nametag-in-range feature is not used, and the nametag-in-range feature is still not used even though I turned off the conditional-nametags feature. Finally, the issue with the unlimited-nametag-mode attribute seems to be fixed in this version.

I know, that's on purpose

In the anti-override.log file this text rarely appears.

10.05.2023 - 14:09:32 - [TAB v4.0.0-SNAPSHOT] Something just tried to add player Test into team ETest (expected team: �26TestA)

this should not appear anymore, delete the file and reload

TeQTabanca commented 1 year ago

The moment I turn on the conditional-nametags feature, the nametag-in-range feature is not used, and the nametag-in-range feature is still not used even though I turned off the conditional-nametags feature. Finally, the issue with the unlimited-nametag-mode attribute seems to be fixed in this version.

I know, that's on purpose

In the anti-override.log file this text rarely appears.

10.05.2023 - 14:09:32 - [TAB v4.0.0-SNAPSHOT] Something just tried to add player Test into team ETest (expected team: �26TestA)

this should not appear anymore, delete the file and reload

Every time the players log into the server, it gives this message.

10.05.2023 - 15:17:58 - [TAB v4.0.0-SNAPSHOT] Something just tried to add player TeqTabanca into team d36b830e-e2de-4 (expected team: ￿20TeqTabancaA)
10.05.2023 - 15:18:07 - [TAB v4.0.0-SNAPSHOT] Something just tried to add player Test into team 478071e1-cc8c-4 (expected team: ￿26TestA)
Tanguygab commented 1 year ago

that's not TAB-Additions

TeQTabanca commented 1 year ago

In the last build of the TAB plugin, your plugin gives an error in the console. (Error)

Tanguygab commented 1 year ago

open new issues when you get a new error unrelated to the current issue. I'll fix it when I come back home