Tanishq4331 / pe

0 stars 0 forks source link

Architecure diagram bugs in DG #12

Open Tanishq4331 opened 2 years ago

Tanishq4331 commented 2 years ago

image.png

These are just a few examples among many which have stray arrows at the top. Not sure of their significance. There is also significant overlap in the labels, titles within the diagrams.

nus-pe-bot commented 2 years ago

Team's Response

"Stray arrows"

The arrows are from the previous diagram which we included below for convenience.

Screenshot 2021-11-13 at 11.04.57 PM.png

These two diagrams are an abstracted out diagrams for the Students and TuitionClass boxes, showing the lower level details, so that the overall model diagram would not be too cluttered.

"Significant overlap"

Assuming the overlaps you are referring to are the all and filtered labels on the arrows, the overlap is very minimal and insignificant, and does not affect readability. It is also a limitation of the plant UML diagram. Furthermore, it is only a cosmetic issue and in the worst scenario, a VeryLow, not High.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since these diagrams are extensions of the Student and Tuition class boxes, the arrows pointing to the TuitionClass and Student should be consistent with the solid arrows that point to the TuitionClass and Student boxes in the overall model diagram (as opposed to the dashed arrows being used currently). The lack of consistency here is still an issue.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]