search

Tanishq4331 / pe

0 stars 0 forks source link

Magic number 18...48 in TimetableUi #18

Open Tanishq4331 opened 2 years ago

Tanishq4331 commented 2 years ago

image.png

nus-pe-bot commented 2 years ago

Team's Response

We feel that there is no need to justify the numbers for UML diagrams. There was an explanation of how we built it below, and thus it is not needed to explicitly mention it here.

IMAGE 2021-11-13 22:11:52.jpg

This UML diagram from the module website also has magic numbers but it is valid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While I do agree that the diagram itself does not need to justify the numbers, the explanation should make it clear as to why a multiplicity of 18..48 (which is not obvious) is being used in the TimeTableHeaderTiming. For instance, in the same diagram, the reader can understand why a TimeTable panel consists of 7 days, and thus no following explanation is required.