nus-pe-bot
commented
2 years ago Team's Response
We intentionally left this as we wanted to give the user more freedom. We discussed this as a team before and felt that some students might either have no NOK or uncomfortable to share their NOK's information. Additionally, in odd scenarios, they may have the same first name and sharing their number with their NOK, especially for younger kids who do not have a phone.
We also feel that having a NOK detail is important especially for tuition teachers, who often teach young children, and to prevent them from forgetting to key in the NOK, we decided to make it compulsory.
Thus we allowed the NOK to have same details as the student.
During our normal functionality, this is also very unlikely to happen, as this issue will only occur if the user intentionally keys in the exact same details for the NOK. This is a very similar scenario to the screenshot, and therefore, even if it is accepted, we feel that it should only be a Low severity.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I agree with your concern that some users might not want to provide their NOK information. However, in such a case the NOK parameter should be made entirely optional, since having duplicate NOK and student information adds no value and is just confusing for the user.
"Additionally, in odd scenarios, they may have the same first name and sharing their number with their NOK, especially for younger kids who do not have a phone." - The app allows matching of the entire name string - not only the first name. A situation where the student and NOK have exactly the same full name and phone number is very unlikely.
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Steps to replicate:
add n/Tim p/98765432 e/johnd@example.com a/John street, block 123, #01-01 nok/ n/Tim p/98765432 e/johnd@example.com a/John street, block 123, #01-01causes a student to be added with details identical to their next-of-kin.
Expected behaviour: The user should not be allowed to enter a next-of-kin with details identical to the student.