Tanishq4331 / pe

0 stars 0 forks source link

Edit command with no changes made is still considered valid #6

Open Tanishq4331 opened 2 years ago

Tanishq4331 commented 2 years ago

Steps to replicate:

  1. addclass cn/CS2103T ct/MON 09:30-11:30 r/70 l/Nex Tuition Center
  2. editclass 1 ct/MON 09:30-11:30

This shows a success message even though no class details have been changed.

image.png

Expected:

The user should be warned that they have not made any changes to their class.

nus-pe-bot commented 2 years ago

Team's Response

These two issues have the same underlying problem, hence should be considered duplicates.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Edit student command success even when no details are changed

image.png


[original: nus-cs2103-AY2122S1/pe-interim#5678] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Screenshot 2021-11-15 at 2.47.03 PM.png

It is very unlikely that the user will edit without changing anything. Also, it does not cause much inconvenience if it throws an error, because even if the user edits it to the same information, it still does what it is supposed to do. Thus, we feel that it should be severity.Low instead of Medium.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]