Tanishq4331 / pe

0 stars 0 forks source link

Fragmented find commands #7

Open Tanishq4331 opened 2 years ago

Tanishq4331 commented 2 years ago

Currently there are a seperate commands for locating a class by different fields, which makes it the commands verbose and tedious to use.

Perhaps a better design could be to unify these commands into one single find command that matches the keyword to all the fields. This might make it much faster to use the app using CLI.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Firstly, this issue is closer to FeatureFlaw not FunctionalityBug, as it works as expected.

telegram-cloud-photo-size-5-6089092680660397824-y.jpg

Even though this suggestion may improve the user experience, we feel that it would require substantial amount of additional effort and it would not be in the scope of v1.4, thus it should not be considered a FeatureFlaw as well.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not agree that such a feature requires substantial effort. A rudimentary way of implementing it may be to simply match the keyword with a string representation of the entire Class object that includes both the classname and the classtiming strings.

In fact, unifying these commands might lead to a simpler implementation by eliminating the documentation and testing overheads of a range of fragmented find commands that match different fields.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]