Tanishq4331 / pe

0 stars 0 forks source link

Inconsistent formatting of amounts #9

Open Tanishq4331 opened 2 years ago

Tanishq4331 commented 2 years ago

$ Amounts are inconsistently formatted.

image.png

image.png

image.png

Perhaps, the dollar amount should not be formatted as code snippet. If it is formatted that way, the snippet should include the entire amount eg. $65. In any case, its formatting should be consistent across the UG

nus-pe-bot commented 2 years ago

Team's Response

$1,000,000 is not a valid input, thus we did not put it in code blocks.

Additionally, $70 and $60 were from examples, and we were showing that they referred to the inputs by the user, while $1,000,000 is just an upper limit set by us.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Based on what you said, valid inputs from examples should be in code blocks. However, there are instances that are not consistent with this convention. I have highlighted one below:

image