TanmayAmbadkar / ResaleValuePrediction

2 stars 1 forks source link

make this repo private #1

Open anujpuri72 opened 4 years ago

anujpuri72 commented 4 years ago

This repo is public so other user users can see this. Also upload there project report ASAP @TanmayAmbadkar

thepushkarp commented 4 years ago

Yeah @anujpuri72 @TanmayAmbadkar. Somebody asked for a project idea for the assignment. This seems a good repo for them to check out :thinking:. Even the code is available to start with.

thepushkarp commented 4 years ago

Don't make this private. How else would others copy your assignment then?

aashutoshrathi commented 4 years ago

I think you also need to remove your DB config, else anyone can wipe it out.

AmanRaj1608 commented 4 years ago

Keep it public but just remove this. You can use env variables.

https://github.com/TanmayAmbadkar/ResaleValuePrediction/blob/master/my.cnf

AmanRaj1608 commented 4 years ago

I made my project repo private and now I can not use Travis ci 😢. Don't be like me. Keep it public.

thepushkarp commented 4 years ago

@AmanRaj1608 Does CI on GitHub Actions support Private Repos?

thepushkarp commented 4 years ago

Like Circle CI? It provides 1000 free monthly build minutes for both Public and Private Repos. We used it for DevFest Website too.

AmanRaj1608 commented 4 years ago

Oh, I thought all ci was paid for private repo's. Thanks, bro 🙏