TanmayPatil105 / procfetch

🎨 Yet another command-line system information utility written in C++
https://tanmaypatil105.github.io/procfetch/
GNU General Public License v3.0
23 stars 11 forks source link

🔒 Add flag for battery #117

Closed TanmayPatil105 closed 1 year ago

TanmayPatil105 commented 1 year ago

Changes proposed

codecov-commenter commented 1 year ago

Codecov Report

Merging #117 (80f6b19) into main (9da2491) will decrease coverage by 0.06%. The diff coverage is 22.22%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   24.60%   24.55%   -0.06%     
==========================================
  Files           4        4              
  Lines         443      448       +5     
==========================================
+ Hits          109      110       +1     
- Misses        334      338       +4     
Impacted Files Coverage Δ
src/main.cpp 20.00% <22.22%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TanmayPatil105 commented 1 year ago

@youpong prefer proposing changes in this PR instead of creating a new PR :)

TanmayPatil105 commented 1 year ago

So, Just b should be added to the optstring argument of getopt(3). Now we are trying to add :b preceded by a colon:

Done

TanmayPatil105 commented 1 year ago

Should I draft a new release or wait until we get all things correct related to INSTALL_LIB_DIR get right? It didn't break the code. So, we can ig.

youpong commented 1 year ago

No need to wait.