search

TanmayPatil105 / procfetch

🎨 Yet another command-line system information utility written in C++
https://tanmaypatil105.github.io/procfetch/
GNU General Public License v3.0
23 stars 11 forks source link

Introduce class Context #98

Closed youpong closed 1 year ago

youpong commented 1 year ago

Description

Introduce class Context which contains PACKAGE_DELIM.

codecov-commenter commented 1 year ago

Codecov Report

Merging #98 (5acafd5) into main (6f93979) will decrease coverage by 0.20%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   27.04%   26.84%   -0.20%     
==========================================
  Files           4        4              
  Lines         403      406       +3     
==========================================
  Hits          109      109              
- Misses        294      297       +3
Impacted Files Coverage Δ
src/fetch.cpp 0.00% <0.00%> (ø)
src/fetch.h 81.69% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

TanmayPatil105 commented 1 year ago

Looks good! Anyway to increase the coverage?

youpong commented 1 year ago

I think the coverage test cannot be increased as far as the modifications in this Pull Request.

TanmayPatil105 commented 1 year ago

LGTM!

youpong commented 1 year ago

So we adopt this PR and discard #97, is that correct?

TanmayPatil105 commented 1 year ago

Yupp