TanukiSharp / MHArmory

Armor Set Search application for Monster Hunter: World
MIT License
26 stars 8 forks source link

Missing search results in 0.8.4 #11

Closed GediminasMasaitis closed 5 years ago

GediminasMasaitis commented 5 years ago

I noticed that upon upgrading from 0.8.2 to 0.8.4 some search results went missing. Here is an example, taken from 0.8.2, both overrides being off:

Missing result: mssingresult

This result doesn't appear in 0.8.4 anymore, and is perfectly valid. I've found that this is because Empress Coil B doesn't get elected for the search. Here is a before and after:

0.8.2: before

0.8.4: after

As you can see, there are other changes as well. I believe there is some incorrectness in the piece election algorithm. The Empress Coil gives only Tool Specialist, so I suppose because of that the election algorithm discards it, but in the end it does end up being a viable solution. I'm not entirely sure how to solve this, I'll try to give it some thought.

TanukiSharp commented 5 years ago

Thank you for reporting this.

As we discussed it on Discord, this is because between 0.0.8.2 and 0.0.8.4, new equipments have been introduced (some gamma armors, and the Drachen armor too) so when only the top best armor pieces are elected, now Empress ones are replaced by gamma ones.

However, there were indeed incorrectness in the equipment election, and this has been addressed in version 0.0.8.5.

Let me know if the latest version also fixes this issue in your other sets or not. Thanks.