TanukiSharp / MHArmory

Armor Set Search application for Monster Hunter: World
MIT License
26 stars 8 forks source link

Suggestion: skill exclusions #2

Closed duckness closed 5 years ago

duckness commented 5 years ago

For example, I have a melee weapon with hidden element and I want to use Non-Elemental Boost. This means that I don't want to see any build with Free Elem/Ammo Up (as it would nullify Non-Elemental Boost) , so it would be nice to exclude sets that have that.

TanukiSharp commented 5 years ago

Thank you for your suggestion.

So I think rather than trying to implement some game logic, I could simply propose a window where the user can simply specify some skills to exclude. Not that hard to do, and generic enough for all-purpose scenarios.

Do you think those skill exclusion settings should be persisted alongside the selected skills in the skill loadout ? I think so, it would make sense and so if you switch skill loadout back and forth, you don't have to keep undoing and redoing skills exclusion.

How do you think ?

duckness commented 5 years ago

rather than trying to implement some game logic, I could simply propose a window where the user can simply specify some skills to exclude. Not that hard to do, and generic enough for all-purpose scenarios.

I think maybe having a Lvl 0 option on the Skills Selector screen would be clean, but the intent and functionality might not be obvious to users (so to fix this, in the description on the right, it should say "Exclude this skill" or something similar). Another way could be to add a filter option on Search Results Sorting. I like the first option more.

Do you think those skill exclusion settings should be persisted alongside the selected skills in the skill loadout ? I think so, it would make sense and so if you switch skill loadout back and forth, you don't have to keep undoing and redoing skills exclusion.

I think so too.

TanukiSharp commented 5 years ago

I like your first option too. I was thinking long ago to make filtering options too, but this is way too much work for the feature to be really neat, and too much work for the very little usage it is going to get from end-users, in my opinion. (that's why Sort results... was named Process results... before, it was suppose to have both sorting and filtering)

Anyway, hereafter is how it is going to look like in the next version, should be coming soon.

image

For now the UI work is done, saving and restoring to user settings file comes for free since this is indeed a "level 0" under the hood. Now I just have to implement skill exclusion in the search algorithm and the feature will be complete ;)

I will update you as soon as it will be finished.

TanukiSharp commented 5 years ago

The implementation is finished, actually it was much simpler than I expected. You can have a try by checking out the commit 9f166f442c609511291456dec1ff685acb080976.

I'm not yet sure if I will release it soon like that or if I wait for another pending feature and ship all at once.

TanukiSharp commented 5 years ago

Hey, the skill exclusion feature has been officially shipped in version 0.0.7.3, alongside with equipment override, another very cool feature you may want to check.

Change log for 0.0.7.3

Let me know if you find any bug or possible improvement, and thanks again for the suggestion, it's a very nice idea ;)

duckness commented 5 years ago

Looks good!