search

TanukiSharp / MHArmory

Armor Set Search application for Monster Hunter: World
MIT License
26 stars 8 forks source link

Event Quest Window Removal #4

Closed xaviex closed 4 years ago

xaviex commented 5 years ago

Removal of the events quest window makes it significantly more difficult for PC Users to do armor set searches with only what has been released on PC, before I could just turn off the events that have not been released, now I have to go through and search for every piece of armor in the armor override that has not been released for PC yet and disable it, this may be more accurate, but it still feels like removed functionality

TanukiSharp commented 5 years ago

Thank you for your input.

I understand your point, the fact is that it is very hard to keep up with all the events and for which platform, and which equipment they reference.

What I can advice you is simply use the save import features, in this case, no matter what event you already did, it will select what you have. This is the best accuracy you can ever have, in a few clicks.

If you do not want to use the import feature, then you can filter out a set by typing its name, and then clicking the narrow button in from of the equipment buttons in order to toggle them all at once.

Sorry for the inconvenience, but I still feel this is an overall gain.

Let me know if you still have concerns or questions.

xaviex commented 5 years ago

I very much understand the difficulty of keeping up with an ever-changing set of spec's in a code-base, though I know a large number of people use armor set finders like this one to find armor that they need to make in order to get the skills they prefer, In this case the save import really is not going to be that useful as the user would not own the items, and they would be excluded on save import (though I will say it is fantastically useful for searching within already created armor) what I might suggest is some way of possibly saving sets of armor exclusions so that they could be user created once than saved (I am sorry if this already exists!) though I really am having trouble thinking of a way to do this cleanly. I would be happy to provide feedback to any other solution you may have, and if I have some free time maybe toss a pull request over

Edit: Also, just noting that the event quest wording is still found within the instructions in the 0.0.8.0 Release

xaviex commented 5 years ago

My bad on that!

TanukiSharp commented 5 years ago

Thanks you for your feedback.

I have to admit your use case sounds perfectly legit and that I never though about that. It makes totally sense.

The idea of having (being able to make) exclusion presets is very good, but also requires a lot of UI work.

The point I wanted to emphasis with the equipment override replacing the events window is that clicking on that:

image

is strictly equivalent of clicking on that:

image

I hope you understand that adding more feature for even finer grain equipment selection and toggling represent a too big amount of work, and that the current equipment override feature can be satisfying enough.

xaviex commented 5 years ago

No problem! I might make a fork and see if I can come up with anything!

TanukiSharp commented 5 years ago

Pull requests are welcome if the work is correctly done.

The community would appreciate your efforts :)

TanukiSharp commented 5 years ago

Note that version 0.0.8.1 has Select all and Unselect all buttons, if that can help a bit with the tweaking.

xaviex commented 5 years ago

Note that version 0.0.8.1 has Select all and Unselect all buttons, if that can help a bit with the tweaking.

This makes this significantly easier to cleanup post first launch

TanukiSharp commented 5 years ago

Hi @xaviex

Any news about a possible PR ?

xaviex commented 5 years ago

Hey! Sorry got very busy with work and some home things, haven't had the time for personal projects lately

On Sun, Mar 17, 2019, 2:05 AM Sebastien ROBERT notifications@github.com wrote:

Hi @xaviex https://github.com/xaviex

Any news about a possible PR ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TanukiSharp/MHArmory/issues/4#issuecomment-473619824, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVYXu_LKKROstcty5Aa4iLGKURGuoO0ks5vXdtCgaJpZM4Y9kqW .

TanukiSharp commented 4 years ago

Sorry but I close this, since it's been more than 1 year now. If you find time, feel free to re-open or create a new issue.