search

TanukiSharp / MHArmory

Armor Set Search application for Monster Hunter: World
MIT License
26 stars 8 forks source link

Search optimization #8

Closed Fatmice closed 5 years ago

Fatmice commented 5 years ago

Okay I'm back with an example where a search that should give result but instead gave nothing. image Here we are searching for Botanist Lv3 Detector Lv1 Forager’s Luck Lv1 Geologist Lv3 Intimidator Lv3 Master Gatherer Lv1 Scent Hound Lv1 Scholar Lv1 Tool Specialist Lv3 Effluvial Expert Lv1 Heat Guard Lv1 This should give exactly 1 match given restrictions on PC sets (excluding Drachen a, Kush y, Kaiser y, Zorah y, Xeno y, Luna y, spring event, summer event, Azure Starlord a...) as found by http://mhw.wiki-db.com image

TanukiSharp commented 5 years ago

Thank you very much for reporting this. I will have a look as soon as I can and keep you posted :)

TanukiSharp commented 5 years ago

Your setup looks correct and tries only 1'351'350 combinations, mine tries 2'407'860 combinations and finds the same result as mhw.wiki-db does.

image

I think you removed the King Beetle / Queen Beetle armor sets thinking it was part of the Autumn event, but it's not. Could you confirm please ?

Thank you.

Fatmice commented 5 years ago

I have the King Beetle but not the Queen Beetle sets. Anyways, I added it, no change to the combinations tried. Did I do something wrong? image

Fatmice commented 5 years ago

Oh hoh, I found what the issue was. Gender needed to be changed to "Male" or "Female" only. In this case, the King and Queen Beetle are not the same thing even though they seems like "male/female" of the armor set. Database tweak is needed? Also on save import, maybe also change the gender? Cheers. image image

TanukiSharp commented 5 years ago

Not sure about importing the gender, it's a bit overkill and I prefer user to set it themselves. It is persisted in user settings so you have to set it only once.

The real problem is more like why when setting gender to both, it does work, this is a real problem I will investigate. When setting both, you should have two results (one with King and one with Queen) instead of zero.

TanukiSharp commented 5 years ago

I've spotted and fixed wrong gender processing bug. So now selected male or female works as before, but selecting both now works as expected.

Note that the amount of combinations grows rapidly, but now when setting both it indeed finds the two sets.

Fixed in commit e8285f6bca2c44fcad0b5ada6d579e9b9103cd19 and will be included in the next release.

Fatmice commented 5 years ago

The King Beetle is for male and its equivalent is Butterfly for female. This set is gotten from getting a Great Hornfly from cultivating. This set is unrelated to the Queen Beetle (female) and its equivalent Butterfly (male)

TanukiSharp commented 5 years ago

According to this page https://monsterhunterworld.wiki.fextralife.com/King+Beetle+Armor+Set it seems what you say is correct. Mixing sets this way doesn't really makes sense to me, but whatever ^^

Do you confirm the algorithm works correctly when setup correctly ? Or do you still have issues ?

Fatmice commented 5 years ago

Algorithm is working correctly when setting up the gender correctly. I'll test again when you release the next version.

TanukiSharp commented 5 years ago

Version 0.0.8.3 has been released which addresses this issue. now setting gender to both works as expected. Sorry for the troubles.

See change log here.

Fatmice commented 5 years ago

Working now.