search

Tanweth / Poll-Box

A plugin for the MyBB forum software that allows a fully-functional poll to be displayed on your home pages.
Other
1 stars 1 forks source link

Suggested bug fixes #3

Closed WildcardSearch closed 10 years ago

WildcardSearch commented 10 years ago

1 where library failed to be included

2 where templates are given an sid of -1 but recent updates have

changed that

Tanweth commented 10 years ago

My apologies for the lack of activity on this. GitHub has not been notifying me when new issues have been posted, so I didn't realize there was any activity on here. I'm about to post a major update to the module, and I'll be sure to include the suggested edits. Thank you for helping to make this a better plugin as always. :)

WildcardSearch commented 10 years ago

No probs.

Just a heads up @Tanweth I am considering some minor changes to the way modules work. Should I act on those changes (and I feel that I will), I'll submit a pull request with the changes you'll need to make. You obviously shouldn't feel pressured to pull it, I just want to keep you up to date.

Just FYI, I am looking to lighten the amount of data needed per module by foregoing passing the entire setting array to the modules and instead sending them only an array of setting values. So $setting['setting_name']['value'] becomes $setting['setting_name'] which is more intuitive anyway. :smile:

Tanweth commented 10 years ago

I'd be happy with that improvement. Thanks for the heads up.