Airports code review

[mandyWW]

Great work Tanya! Just a few comments below:

• beautifully laid out code (capitalisation of class names, clear test naming structure)
• (minor) rename Crewmember to CrewMember (I am so fussy!). Also rename associated test.
• any reason you default the CrewMembers bags and total bags?
• Person class, total bags should be something you derive rather than pass in i.e from the size of the array
• your Passenger test implies to me the array is holding both numbers of Bag objects.. i.e you construct a Passenger as follows const phoebe = new Passenger(149587, "Phoebe", 2, [10, 24]); i.e. with 2 bags, number 10 and number 24. But then later you call addBag with a Bag object. I think you Passenger constructor (and Person constructor) need to take Bag objects not numbers (ask me for clarification if you need)

Questions (please reply on Slack)

• did jsdoc run ok? You can use jsdoc . to run on all files and generate an index.html for all classes
• what test coverage do you have?

[TanyaJRB]

Thank you, Mandy! I will reply to your comments on Slack as requested.

Tanya Rashid +447392260579

On 13 Jan 2021, at 22:24, mandyWW notifications@github.com wrote:



Great work Tanya! Just a few comments below:

• beautifully laid out code (capitalisation of class names, clear test naming structure)
• (minor) rename Crewmember to CrewMember (I am so fussy!). Also rename associated test.
• any reason you default the CrewMembers bags and total bags?
• Person class, total bags should be something you derive rather than pass in i.e from the size of the array
• your Passenger test implies to me the array is holding both numbers of Bag objects.. i.e you construct a Passenger as follows const phoebe = new Passenger(149587, "Phoebe", 2, [10, 24]); i.e. with 2 bags, number 10 and number 24. But then later you call addBag with a Bag object. I think you Passenger constructor (and Person constructor) need to take Bag objects not numbers (ask me for clarification if you need)

Questions (please reply on Slack)

• did jsdoc run ok? You can use jsdoc . to run on all files and generate an index.html for all classes
• what test coverage do you have?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTanyaJRB%2FWhiteHat%2Fissues%2F1&data=04%7C01%7C%7Cf47a9c93b03f4c3a8ce908d8b8120c8e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637461734940957433%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gku%2BvlkhEhBJKMF5HbFIUqJ72UdSHCUm2cUAPXKiQ8g%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASHGKIFPKHP6EB62C7PHCPLSZYMTJANCNFSM4WBQFP3Q&data=04%7C01%7C%7Cf47a9c93b03f4c3a8ce908d8b8120c8e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637461734940957433%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tnw42AlrozR%2BZVVQ9uMN2gGz1ywxj9ufqHMvADQ0Pvs%3D&reserved=0.