Tanza3D / reddark

reddark, but it's in realtime
GNU Affero General Public License v3.0
298 stars 41 forks source link

Add search bar #27

Closed Krafalski closed 1 year ago

Krafalski commented 1 year ago

Hello,

I really like your project. I added a search bar. I wasn't sure how to connect the file /public/search.js correctly, since I only ran the front end (I didn't use the server - it kept timing out). I followed the pattern you had in your index.html.

Let me know if you would like me to make any changes.

Tanza3D commented 1 year ago

not sure what you've done here but it's really messed up the styling, i'll try to fix it and merge this

Krafalski commented 1 year ago

@Tanza3D Oh no! I'm not sure what went wrong. I added a form in the .amount div in index.html

As far as style, the end result looked like this (search bar in the .amount div).

Screenshot 2023-06-11 at 7 17 30 AM

To accomplish this, I added the following CSS (and did not edit the styles you had):

.amount {
  display: flex;
  justify-content: space-around;
}

.filtered {
  display: none;
}

I hope that is helpful. I can make updates on my end.

Tanza3D commented 1 year ago

added at https://github.com/Tanza3D/reddark/commit/579cf220711d99622141fc12ad99ab096e85106e (used your code, just did this to save git conflict hastle)

Krafalski commented 1 year ago

I think the updates you made to the appearance look great.

I am sorry that my code couldn’t be merged in as I don’t show up as a contributor.

Thank you for reviewing my code.

Tanza3D commented 1 year ago

sorry about that, i left a comment in the code crediting you atleast

Krafalski commented 1 year ago

Thank you, it is appreciated.On Jun 11, 2023, at 09:25, Tanza @.***> wrote: sorry about that, i left a comment in the code crediting you atleast

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>