search

Tanzu-Solutions-Engineering / PCF-Sizer

Costing / Sizing tool
Apache License 2.0
18 stars 7 forks source link

Health Manager not needed with Diego #2

Closed gtantachuco closed 8 years ago

gtantachuco commented 8 years ago

Hey guys, Nice work keeping Shekel up-to-date. Just noticed something really minor. The 1.6 estimate includes 1 Health Manager, which is no longer needed when using Diego per: http://docs.pivotal.io/pivotalcf/opsguide/diego-overview.html Here is an excerpt: "In the PCF 1.6 release, Diego replaces the DEAs and the Health Manager. Diego is installed and enabled in PCF 1.6 by default."

virtmerlin commented 8 years ago

Thats an old build "what u asked for". We fixed in a newer build

On Friday, January 8, 2016, Guillermo Tantachuco notifications@github.com wrote:

Hey guys, Nice work keeping Shekel up-to-date. Just noticed something really minor. The 1.6 estimate includes 1 Health Manager, which is no longer needed when using Diego per: http://docs.pivotal.io/pivotalcf/opsguide/diego-overview.html Here is an excerpt: "In the PCF 1.6 release, Diego replaces the DEAs and the Health Manager. Diego is installed and enabled in PCF 1.6 by default."

— Reply to this email directly or view it on GitHub https://github.com/pivotalservices/shekel/issues/2.

Merlin Glynn mglynn@pivotal.io 001-214-551-8074

gtantachuco commented 8 years ago

The latest build at: https://pcfsizer.cfapps.pez.pivotal.io shows 3 Health Managers:

screen shot 2016-01-08 at 5 25 07 pm
krujos commented 8 years ago

Thanks for letting us know. Would you mind submitting a pr (/is/data/ers*.json has the file, should be pretty self explanatory. In our and about or id just do it. On Fri, Jan 8, 2016 at 5:26 PM Guillermo Tantachuco < notifications@github.com> wrote:

The latest build at: https://pcfsizer.cfapps.pez.pivotal.io shows 3 Health Managers:

[image: screen shot 2016-01-08 at 5 25 07 pm] https://cloud.githubusercontent.com/assets/612601/12212170/e36639a8-b62c-11e5-8e8f-ee5b3d0f650c.png

— Reply to this email directly or view it on GitHub https://github.com/pivotalservices/shekel/issues/2#issuecomment-170155447 .

rjain-pivotal commented 8 years ago

Committed the change.