search

Tanzu-Solutions-Engineering / pcf-ers-demo

Pivotal Cloud Foundry Elastic Runtime Service basic demo
BSD 2-Clause "Simplified" License
37 stars 1.22k forks source link

Add projectlombok version #7

Closed jimbasler-pivotal closed 8 years ago

jimbasler-pivotal commented 8 years ago

This fixes an issue with the mvn install command that would error out without it.

jimbasler-pivotal commented 8 years ago

At least a few people have run into an issue with the projectlombok dependency. Adding version fixes it.

mborges-pivotal commented 8 years ago

were you able to merge this? I'm seeing a different version in the pom.xml, so I'm not sure where we are with this. Let me know and I'll merge the pull request. Thanks!

jimbasler-pivotal commented 8 years ago

It looks like it is there now.

Thanks.

Jim

Jim Basler | Pivotal Cloud Application and Platform Architect Agile Strategy, Transformation, and Enterprise Architecture (TOGAF) Ph: 1-920-410-6408 | jbasler@pivotal.io jbasler@pivotal.io

Platform as a Service | Agile Development | Big Data www.Pivotal.io http://www.pivotal.io/

Our mission is to transform how the world builds software. In 2013 Pivotal was deliberately created to be a special company. A company built on an indelible culture, based on a common set of values and beliefs called the Pivotal Principles—Do What Works, Do What’s Right, Be Kind. Great companies are built by great cultures.

[image: SpringOne 2016] http://springoneplatform.io/

On Thu, Jun 2, 2016 at 11:08 AM, Marcelo Borges notifications@github.com wrote:

were you able to merge this? I'm seeing a different version in the pom.xml, so I'm not sure where we are with this. Let me know and I'll merge the pull request. Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Pivotal-Field-Engineering/pcf-ers-demo/pull/7#issuecomment-223340312, or mute the thread https://github.com/notifications/unsubscribe/AKfAc1nn41_R3aEnnpBNZFGlr9AcIzitks5qHv_8gaJpZM4Iss59 .

jimbasler-pivotal commented 8 years ago

I saw someone else had a pull request, so I closed mine with a comment. Note that I used Lombok 1.16.8 which is a little more recent and it worked fine.

mborges-pivotal commented 8 years ago

Ah, now it makes sense. Should we re-open yours and get the most recent version? Let me know whatever is easier for you. I'm in favor to reopening and adding the most recent version. Thanks!

jimbasler-pivotal commented 8 years ago

Reopening to add more recent version.

jimbasler-pivotal commented 8 years ago

Done. I reopened it.

Thanks.

Jim

Jim Basler | Pivotal Cloud Application and Platform Architect Agile Strategy, Transformation, and Enterprise Architecture (TOGAF) Ph: 1-920-410-6408 | jbasler@pivotal.io jbasler@pivotal.io

Platform as a Service | Agile Development | Big Data www.Pivotal.io http://www.pivotal.io/

Our mission is to transform how the world builds software. In 2013 Pivotal was deliberately created to be a special company. A company built on an indelible culture, based on a common set of values and beliefs called the Pivotal Principles—Do What Works, Do What’s Right, Be Kind. Great companies are built by great cultures.

[image: SpringOne 2016] http://springoneplatform.io/

On Thu, Jun 2, 2016 at 11:22 AM, Marcelo Borges notifications@github.com wrote:

Ah, now it makes sense. Should we re-open yours and get the most recent version? Let me know whatever is easier for you. I'm in favor to reopening and adding the most recent version. Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Pivotal-Field-Engineering/pcf-ers-demo/pull/7#issuecomment-223344375, or mute the thread https://github.com/notifications/unsubscribe/AKfAc87mwqKAMayg3XArRnR4kOEoOqZHks5qHwMvgaJpZM4Iss59 .