Closed doddatpivotal closed 3 years ago
lgtm
@doddatpivotal I have a question: Did you run into issues that motivated the change on the pinniped-addon secret? Or is this just to improve our scripts to patch instead of replace add-on secrets, since that seems to be the convention from the R&D team?
@jaimegag I never saw a R&D convention. I had originally wrote the previous logic through trial and error and it was confusing. I thought patching was much cleaner and didn't have to maintain the knowledge (and potentially out of date implementation) of the required annottations.
Adds tags for azure and optimizes the update pinniped script.