TaoK / PoorMansTSqlFormatter

A small free .Net and JS library (with demo UI, command-line bulk formatter, SSMS/VS add-in, notepad++ plugin, winmerge plugin, and demo webpage) for reformatting and coloring T-SQL code to the user's preferences.
http://www.architectshack.com/PoorMansTSqlFormatter.ashx
GNU Affero General Public License v3.0
957 stars 266 forks source link

Support Azure Data Studio #208

Open asjones987 opened 5 years ago

asjones987 commented 5 years ago

Azure Data Studio, works with both Azure and on site MS SQL server. Azure Data Studio is also open source so it would be supporting a related product. There is Extension support that would be perfect for PoorMans TSQL formater.

https://github.com/Microsoft/azuredatastudio

https://docs.microsoft.com/en-us/sql/azure-data-studio/what-is?view=sql-server-2017

aktenkundig commented 5 years ago

You can install the Visual Studio Code Extension. It works in Azure Data Studio.

asjones987 commented 5 years ago

@neo6238, I have Visual Studio Code installed. A little confused. Azure Data Studio dos not see the extension in the Market Place. Visual Studio Code does see the Extension so I installed it, but that did not "do anything" for Azure Data Studio. What am I missing?

thanks

Alan

dzsquared commented 5 years ago

If @TaoK would package the VS Code extension to vsix and upload it as a release, it could be directly loaded into Azure Data Studio. From there its a few quick steps to also publish to the Azure Data Studio extension marketplace.

Without the extension package readily available, the most direct way to load into Azure Data Studio is add it to VS Code, then dig into the extensions directory for VS Code and find the vsix file. In Azure Data Studio, open the command pallette and select install from vsix, selecting that file.

aktenkundig commented 5 years ago

@asjones987

Oh yes, you can download the VSIX file here: https://marketplace.visualstudio.com/items?itemName=TaoKlerks.poor-mans-t-sql-formatter-vscode

And then install it in Azure Data Studio like described: File -> Install Extension from VSIX Package.

asjones987 commented 5 years ago

@TaoK I saw you were posting a few things and responding to issues. Are you activly working on PoorMansTSqlFormatter again?

TaoK commented 5 years ago

Hi @asjones987, I do what I can, but in the last year unfortunately that's meant almost nothing. Last month I updated my hosting credit card details so that downloads could resume when my hosting accidentally cut out, and yesterday I fixed the manual install instructions and prepared the plugin marketplace listing in Notepad++'s new plugin admin infrastructure, so that existing Notepad++ users wouldn't suddenly lose access. I've probably done a few other things over the course of the year that I don't remember, when something threatens to "take away" this tool that I think a few hundred or thousand people now rely on on a daily basis.

I haven't set aside any time for Azure Studio support (I've never even seen/installed Azure Studio - I assume it's an evolution of SQL Operations Studio??) - I see that @dzsquared has prepared an Azure Studio-targeted version of the VS Code plugin with VSIX file at https://github.com/dzsquared/poor-mans-t-sql-formatter-azuredatastudio-extension/releases/tag/1.7.0, which is super-cool, I will take a look at that when I can - if it's easily adaptable into a "general" release process I imagine I can get that properly released into the marketplace (I assume that's what https://marketplace.visualstudio.com/azuredevops is...?) at some point over the next few days / weeks... but unfortunately I'm in no position to make any commitments.

As you can probably tell from my cluelessness, I no longer work with an MS stack on a day-to-day basis, so every time I get a chance to dive back into this project, I have to spend a little time "catching up". The corresponding rising pile of newer T-SQL dialect issues is a little intimidating.

It's also hard, with this kind of project, to determine where to spend your "attention credit" - to benefit as many people as much as possible. Based on the interest here and on twitter, it looks like Azure Data Studio support might be a good bet. I'll tag accordingly.

TaoK commented 5 years ago

Updated issue name - whether or not support is added for recent SSMS versions is somewhat immaterial to whether or not an official Azure Data Studio marketplace release is made available.

asjones987 commented 5 years ago

Silly question in VS Code or Azure Data Studio how do you tell it to format the code? I did not see the usual menu items or entries like SSMS or other tools. ADS has a format, but seems to be an internal format tool not Poor Man's

dzsquared commented 5 years ago

@asjones987 not a silly question! to tell the extension to format the code (or do anything), open the command pallete (ctrl+shift+p) and search for "format". The option for formatting the code should come up.

TaoK commented 5 years ago

Please note, there is now a mechanism for releasing Azure Data Studio extensions onto its limited marketplace, and someone has packaged some version of Poor Man's T-SQL Formatter onto this marketplace. I still think there should be an official release, but the urgency has significantly dropped.

dzsquared commented 5 years ago

If you want any feature changes to the unofficial extension currently listed in the Azure Data Studio marketplace, here's the repo: https://github.com/wsr-publishing/azure-poor-formatter

Keep in mind that you can install any compatible .vsix in Azure Data Studio, even if it is unlisted.