search

TaoK / PoorMansTSqlFormatter

A small free .Net and JS library (with demo UI, command-line bulk formatter, SSMS/VS add-in, notepad++ plugin, winmerge plugin, and demo webpage) for reformatting and coloring T-SQL code to the user's preferences.
http://www.architectshack.com/PoorMansTSqlFormatter.ashx
GNU Affero General Public License v3.0
964 stars 267 forks source link

Support for Visual Studio 2022 #284

Closed WilliamRobertson09 closed 1 year ago

WilliamRobertson09 commented 2 years ago

Pull request details

Use this tool often for SQL projects and was great in Visual Studio 2019. Noticed that a little bit changed in how VSIX projects were managed in visual studio 2022 so decided to create a new project that used the SSMSLib in VS2022.

As a part of this development went through quite a few hurdles getting the project to build in Visual studio 2022 and I think that is due to the fact that the project was being maintained in Visual Studio 2013. Nuget has gotten quite a bit smarter as well as build processes, so a few packages.config files have been updated as well as some project configuration files

Breaking changes

I'm not 100% convinced that key board shortcuts work anymore. Was having issues migrating that part to VSIX for 2022. Would appreciate if anyone can work it out.

Issues fixed

  1. New project allows the VSIX to be used in Visual Studio 2022

Notes

Welcome any feedback from those who may be more adept at making extensions for visual studio as this is my first time delving into this type of project.

lennybacon commented 1 year ago

What is the difference to #275?

WilliamRobertson09 commented 1 year ago

What is the difference to #275? @lennybacon

From looking at your changes, I've taken the approach of adding packages.config file as well as the Solution build steps to avoid having to hardcode the version numbers as you did (as well as forcing visual studio to build the projects with the correct version of the SDK). I believe your approach to fixing this issue when building was to "...fix the version numbers of the references projects."

I was unable to get your branch to build successfully in my install of Visual Studio 2022 to install it (this was before someone kindly put it on the Visual Studio marketplace).

I will close this merge request as the intention of both merges are the same, and your approach has been proven through real world use.

WilliamRobertson09 commented 1 year ago

Duplicate of #275