search

Tapadoo / Alerter

An Android Alerting Library
MIT License
5.52k stars 633 forks source link

S10 overshoot fix #237

Closed AJScanlan closed 4 years ago

AJScanlan commented 4 years ago

@kpmmmurphy finally got a chance to use this library :D

Noticed some overshooting on my S10 though, quickest way I thought to fix was increase the negative margins. This works but moves the alert up slightly in its resting position versus the original margins.

To my eye it's ok but if you think it will cause issues let me know if there's a better way, been a while since I did Android.

20200903_134715 20200903_134852

kpmmmurphy commented 4 years ago

Hey @AJScanlan, thanks for your PR! Looks good to me. I've wrestled with this in the past, and the original padding value was arbitrarily chosen. I think in the future I may change it to a calculated percentage of the screen.

I've just merged another PR, which bumps the version to 6.2.0. Could you alter your PR version to 6.2.1 in the build.gradle, and the changelog - then I'll merge?

AJScanlan commented 4 years ago

Yeah I was considering something similar to calculating the height but didn't want to mess with it too much since I don't know fully how it all works and didn't want to break this very popular library ;)

Sure thing, I'll update now