Fix. Extra bottom margin when displayed with Gravity.BOTTOM

Tapadoo / Alerter

An Android Alerting Library

MIT License

5.52k stars 633 forks source link

Fix. Extra bottom margin when displayed with Gravity.BOTTOM #268

Closed vshkl closed 3 years ago

vshkl commented 3 years ago

What this PR does:

This PR fixes Alert may has extra bottom margin when displayed with Gravity.BOTTOM issue. Getting navigationBarHeight by subtracting (usableScreenHeight) and all possible cutouts (cutoutsHeight) from the physical screen height (physicalScreenHeight).

Demos left to right:

OnePlus 5 Android 10 w/o and w/ virtual navigation bar
Xiaomi Mi A2 Android 11 w/ full and gesture navigation bars
Pixel 3 XL Android 9 with top notch to test with extra cutouts

kpmmmurphy commented 3 years ago

Hey @vshkl, this looks great! Thanks for getting to this so swiftly! Before we merge, please update the library version in the build.gradle, and update the changelog.

vshkl commented 3 years ago

@kpmmmurphy, done.