search

Tapadoo / Alerter

An Android Alerting Library
MIT License
5.52k stars 633 forks source link

Add support for elevation #273

Closed anderscheow closed 3 years ago

anderscheow commented 3 years ago

This PR allows user to set elevation to the alert background.

kpmmmurphy commented 3 years ago

That's awesome @anderscheow, thanks for this! We're good to merge, once you update the library version, and changelog! 🙌

anderscheow commented 3 years ago

Done updating the version and changelog!

anderscheow commented 3 years ago

Somehow release 7.2.3 doesn't include this changes. Can you check on it?

kpmmmurphy commented 3 years ago

Apologies @anderscheow, I've updated the tags now to reflect the correct commits. Please try again now

anderscheow commented 3 years ago

I just checked, still the same.

anderscheow commented 3 years ago

I suggest to bump another version, because Jitpack already cached for 7.2.3

kpmmmurphy commented 3 years ago

Apologies. I've updated the release again... Please clear you local Gradle cache and try again!

anderscheow commented 3 years ago

Thanks mate!

anderscheow commented 3 years ago

Hi sorry to disturb again. Seems like the Jitpack not updated the 7.2.3 with the latest changes that you've done. https://jitpack.io/#Tapadoo/Alerter

kpmmmurphy commented 3 years ago

Sorry @anderscheow, I've gone ahead and bumped to 7.2.4! Tested locally myself, and your code is included this time!

anderscheow commented 3 years ago

Much appreciated!