search

Tapanila / SharpCaster

Chromecast C# SDK for .net standard 2.0
MIT License
309 stars 49 forks source link

"Queuecaster" feature enhancement #294

Closed RobertK66 closed 4 months ago

RobertK66 commented 4 months ago

This adds following Cast Messages/Models: QueueLoad, QueueNext, QueuePrev, QueueChange, QueueItemIds, QueueItems

What I did:

Tapanila commented 4 months ago

I made some changes on https://github.com/Tapanila/SharpCaster/commit/43788e4530cc9973e09453ad2efe8a5d1e05945d. If you can just pull those changes in I'm fine with merging

RobertK66 commented 4 months ago

Wow, thx. for cleaning up my messy left behinds and non formatting ;-)....

What I think you missed, is that I intentionally used and expanded your existing Media.Item class because this is the same object used in the MediaStatus answer and in the QueueLoad (see here and here ). So I think we should delete the Media.Item class and always use the QueueItem for that. You can also see in the LOG after a QueueLoad the mediaStatus contains 2 items (current and next) and both of them have the orderId field set! The separation in the 2 Namespaces is therefore not that clean as you tried to do it 😄 ....

BTW: Does the "CD" list of audio tracks somehow show on a Cast Video device (unfortunately I do not have one) !? ( Your Example Video in the Load Tests perfectly plays its Audio Track on my Speakers )

Tapanila commented 4 months ago

I agree on deleting the Media.Item class. it makes more sense because it's pretty empty class currently.

My SharpCasterDemoApplication that's used on the testing doesn't have a UI elements to show what's playing so there's no feedback on what it's playing.

RobertK66 commented 4 months ago

But can you hear the Audio?

Tapanila commented 4 months ago

Yep and all controls work fine