Tape-Dispenser / Immersive-Music-Mod

GNU General Public License v3.0
15 stars 2 forks source link

Incompatibility with the "Biome Music" mod #29

Open Mandragorat opened 2 months ago

Mandragorat commented 2 months ago

The music from the mod "The Immersive Music Mod" simply does not play. (The added music from the game menu does play, but the rest does not)

Tape-Dispenser commented 2 months ago

please upload your latest.log file. also what are your delay values set at? by default the mod waits between 20 seconds and 3 minutes between songs

Mandragorat commented 2 months ago

My mod version: timm-1.0.3 for Forge 1.20.1

My log file: 2024-09-12-2.log.gz

I did some further research and read that the issue was with the Terralith biomes not playing the new music. So, that part is resolved. However, another issue has arisen:

1) I can't use the commands:

2024-09-12_19 46 01 2024-09-12_19 46 34 2024-09-12_19 46 52 2024-09-12_19 46 59

2) In the "biome_playlists.json" file, I removed the line "menu":["timm"] to prevent the TIMM music from playing in the game menu. This worked, but now the music from my resource pack (which I created) that specifically changed the game menu music is not playing. Instead, the Minecraft music is playing. Its functionality is easily explained. Basically, I just changed the name of my music to match Minecraft's music so that Minecraft would play it instead of its own music.

Pls help

Tape-Dispenser commented 2 months ago

support for terralith biomes is going to be added tomorrow, all it requires is an updated config file, if you're in our discord server the updated config will be posted there, as for the commands issue I've seen this before but i'm not entirely sure what causes it, if you could send a modlist that would be appreciated as i believe it is some sort of compatibility issue. Finally, the current forge version was not written by me, and there have been a couple of issues with it so far that i'm not sure how to go about fixing, but these should be addressed in the upcoming version of the mod where I will be writing a dedicated forge port

Mandragorat commented 2 months ago

I have a lot, here is an Excel file for you:

Mods.xlsx

Tape-Dispenser commented 2 months ago

as for your menu music problem, rather than deleting the entry from biome_playlists you can just add the song id of your music to the playlist. if it overwrites minecraft's menu music i'd assume you just have to put minecraft:music.menu. you can also delete the timm:menu entry from that playlist if you wish.

Tape-Dispenser commented 2 months ago

thanks for the mod list, i'll have to do some investigating

Mandragorat commented 2 months ago

as for your menu music problem, rather than deleting the entry from biome_playlists you can just add the song id of your music to the playlist. if it overwrites minecraft's menu music i'd assume you just have to put minecraft:music.menu. you can also delete the timm:menu entry from that playlist if you wish.

OMG! You're right! Of course, if "minecraft:music.game" exists, how did I not think that I could also use "minecraft:music.menu"? It would look like this: "menu":["minecraft:music.menu"]

I apologize for my blindness, I'll test it now, but in theory, it should work without any issues.

Tape-Dispenser commented 2 months ago

yeah that looks right

Mandragorat commented 2 months ago

Works perfectly, thank you very much