search

Tapico / tapico-msw-webarchive

An utility to drive requests handlers through a `.har` web-archive file
MIT License
98 stars 8 forks source link

Search queries not taken into account when defining request handlers #82

Closed hugosoares closed 2 days ago

hugosoares commented 2 months ago

https://github.com/Tapico/tapico-msw-webarchive/blame/4a77d804d068ff9fc1a6575c84b087b37d8087d7/src/serverHandler.ts#L100

Then above line of code does not make much sense since it completly ignores the search query making every single response the same even if the har file contains multiple different responses for every search query.

Example: https://myjira.atlassian.net/rest/api/3/project/10147/version?startAt=0&maxResults=50&orderBy=releaseDate&status=unreleased https://myjira.atlassian.net/rest/api/3/project/10147/version?startAt=0&maxResults=50&orderBy=releaseDate&status=released

AS IS These two requests will be handled the same way providing the same result, Expectation An individual response should be given for each request

github-actions[bot] commented 1 month ago

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

weyert commented 1 month ago

Think this should be covered in the @mwsjs/source-package.

github-actions[bot] commented 1 week ago

Oops! It looks like we lost track of this issue. What do we want to do here? This issue will auto-close in 7 days without an update.

github-actions[bot] commented 2 days ago

This issue was auto-closed due to inactivity. While we wish we could keep responding to every issue, we unfortunately don't have the bandwidth and need to focus on high-value issues.