search

Tapico / tapico-turborepo-remote-cache

A server for TurboRepo Remote Cache to store cache artefacts in Google Cloud Storage or Amazon S3
MIT License
133 stars 10 forks source link

Fixes teamId query param handling #5

Closed amirilovic closed 2 years ago

amirilovic commented 2 years ago

Hi,

Thanks for starting the project, I was playing around with the server and discovered couple of bugs along the way and this PR should fix them.

First issue is with teamId query param it should be teamId instead of teamID, here is the reference from the client https://github.com/vercel/turborepo/blob/main/cli/internal/client/client.go#L76

Second issue is with artifact download, I'm not a go expert, but it seems to me that current code is only writing first 5 bytes, so I used io.Copy to copy the whole stream to the output.

I also added some notes in the docs which I had trouble with.

Let me know what you think.

Cheeers!

tapico-weyert commented 2 years ago

Awesome, thank you very much! Greatly appreciated

I thought I fixed the issue with teamId vs teamID I introduced that problem because of trying to fix linting issue and the Go linter prefers ID over Id 🤷‍♀️