TappNetwork / laravel-uppy-s3-multipart-upload

Multipart Uploads using Laravel, AWS S3, and Uppy
MIT License
69 stars 18 forks source link

Variable not initialized #1

Closed jtrod closed 3 years ago

jtrod commented 3 years ago

Hi great package, very helpful.. Thanks a lot.

I was wondering where the $partResponse['NextPartNumberMarker'] is being initialized at line 172. My IDE flags it as not initialized, even though this being a recursive call.

https://github.com/TappNetwork/laravel-uppy-s3-multipart-upload/blob/4d00b9edba34e83a011482ea3691637270df971f/src/Http/Controllers/UppyS3MultipartController.php#L157-L175

andreia commented 3 years ago

@jtrod Thank you, really glad you found it helpful! I just added a fix. Please let me know if everything is okay :)

jtrod commented 3 years ago

Awesome! Thanks for sharing this with the community! Very helpful!