search

TappNetwork / laravel-uppy-s3-multipart-upload

Multipart Uploads using Laravel, AWS S3, and Uppy
MIT License
69 stars 18 forks source link

Remove unnecessary .env vars from setup instructions #15

Closed kerkness closed 1 year ago

kerkness commented 1 year ago

AWS_URL and AWS_POST_END_POINT environment variables are now dynamically determined by the aws-sdk-php package. Setting these to any value will make the sdk automatically assume you are using a custom endpoint and prevent the use of accelerator,

Fixes #14

andreia commented 1 year ago

Thank you @kerkness for this PR and for taking the time to investigate this!

stobrien89 commented 1 year ago

@andreia, @kerkness

FWIW it might be worth adding those back and just mentioning that they are optional, i.e. should only be used if a customer is using a custom, non-aws endpoint. I could see the lack of documentation for those two env vars causing confusion for those who may be using a 3rd party object store. Definitely not the common case, but it's something to keep in mind.

andreia commented 1 year ago

@stobrien89 @kerkness Yeah, added a note in https://github.com/TappNetwork/laravel-uppy-s3-multipart-upload/pull/16