search

TarHeelBiostatistics / DoctoralThesisTexTemplate

LaTeX Template for Doctoral Theses. NO guarantee that this is up to date with current UNC-CH Graduate School's formatting guidelines.
GNU General Public License v3.0
3 stars 4 forks source link

Removed and ignored .DSstore #11

Closed phoebejiang closed 7 years ago

phoebejiang commented 7 years ago

This pull request is made in response to the issue #10.

I removed the .DSstore from my local machine (commit no. is ae2e733) and added *.DSstore to the .gitignore file. Please see files changed for details.

BarkleyBG commented 7 years ago

You don't provide a description. Could you please write a description of what changes you made, possibly referencing the issue that you're attempting to fix (use the hastag notation to refer to issues or PR's)

BarkleyBG commented 7 years ago

Thanks for the updated comment.

  1. it seems that there's still a 3rd file that needs to be removed, could you look for that?
  2. I mistakenly wrote the files as .DSstore, but it seems that they're .DS_Store. Could you make that change in the .gitignore file?

Lastly, when you're done with those two, use one of the verbs shown here to close the issue when the PR is merged

phoebejiang commented 7 years ago

  1. I only saw two. One in the main folder and one in Template_2. See "files changed" for those two changes. I remember there was another one in Template_3, but I don't see it anymore. Do you see a third one?

  2. I fixed it on my local machine and I recommitted it.

I assume I need to wait until the PR is merged before I close the issue?

BarkleyBG commented 7 years ago
  1. You're right, I only see two now.
  2. You may need to match cases exactly : .DS_Store not .DS_store
  3. I'll demonstrate the verb usage:

Fixes #10

The issue will auto-close when this PR is merged.

phoebejiang commented 7 years ago

Yeah I realized the "s" should be uppercase too.